Fix examples loading and stale PWA assets - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two causes of example-loading problems:
app.js,app.css,manifest.webmanifest) to network-first with cache fallbackWhy
Example content was previously created only when
mathnotebook_v1did not exist. Users with existing notebook data therefore had no way to reload the built-in examples.Also, the service worker used cache-first for the fixed-name
app.jsandapp.css. On the first reload after a GitHub Pages deployment, the old active service worker could serve the previous JavaScript bundle even while the new HTML was already online.The new behavior keeps offline support while preferring the latest core app files whenever the network is available.