Use versioned bundles to prevent stale UI after deploys - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the recurring case where MathNote renders but the UI becomes non-interactive after a GitHub Pages/PWA deployment.
Root cause
The application bundle was always published at fixed URLs:
./app.js./app.cssWith a service worker and browser HTTP cache in front of GitHub Pages, an HTML document from one deployment could be paired with JavaScript/CSS from another deployment. A single DOM mismatch can then stop application initialization and make every control appear dead.
Fix
./assets/app-<hash>.js./assets/app-<hash>.cssdist/index.htmlupdateViaCache: 'none'Recovery behavior
Even an older active MathNote service worker does not have a cached entry for a newly hashed bundle URL, so once it receives the new HTML it must fetch the matching new bundle from the network. Old HTML continues to reference its matching old bundle. This removes cross-deployment HTML/JS mixing by construction.