[rparke]

to make this as generic as possible we should only care about the placeholder name. Filenames are "optional" when sending via the API, but are set automatically when sent via admin. We should record both cases and therefore use the templates placeholder to identify the file instead of filename.

[rparke]

Ignore the squawk error - it's unhappy with a column rename. This shouldn't break anything because there isn't even a SQLAlchemy model wrapping this table.

[CrystalPea]

We had a good convo with Richard, about what would be passed to the placeholder column. I thought it worth sharing on the PR page:

So if I had the this template:

and this template email file:

and I would send an API request like:

from notifications_python_client import prepare_upload

with open("file.pdf", "rb") as f:
    ...
    personalisation={
      "first_name": "Amala",
      "appointment_date": "1 January 2018 at 1:00pm",
      "link_to_file": prepare_upload(f, filename="Amala_invite.pdf"),
    }

  response = notifications_client.send_email_notification(
      email_address="amala@example.com",
      template_id="9d751e0e-f929-4891-82a1-a3e1c3c18ee3",
      personalisation=personalisation
  )

placeholder column would be populated with:

• tamagotchi.jpeg for the file uploaded via UI
• link_to_file for the file provided in the API request

filename column would be:

• tamagotchi.jpeg for the file uploaded via UI
• Amala_invite.pdf for the file provided in the API request (if we didn't set the filename in that request, the filename would be set to None here.