Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes for #1194, tested with WhatsApp Desktop (Store/MSIX) on Windows 11 25H2.
Clicking opens the chat. WhatsApp declares its toast activator in its
AppxManifest.xml(ToastNotificationActivation/ToastActivatorCLSID), not in the registry or on its Start menu shortcut, so_find_activatorfound nothing and the click fell back to showing the app. It now reads the manifest as a last step._get_install_foldermoved totoast_activation.pyasget_install_folder, sincewindows_notification.pyalready imports that module and the other way round would be circular.Sender photos. WhatsApp sends the sender's photo as an https URL. Windows has already downloaded it to draw the toast and records where it saved it under
HKCU\Software\Microsoft\Windows\CurrentVersion\PushNotifications\wpnidm(Url,LocalPath)._get_image_pathnow takes that local copy for web images, and only if it lies inside thewpnidmfolder. YASB never fetches anything itself, which would also tell the sender when the menu was opened. This key is undocumented, so if you'd rather not rely on it, the second commit can be dropped on its own.Both have unit tests; ruff and pyright are clean.
With both fixes and your ordering change, the newest WhatsApp message is on top and shows the sender's photo (name and photo hidden here):