Repository navigation
Close HTTP/2 socket on shutdown without active streams - #401
Open
kafkiansky wants to merge 1 commit into
Open
kafkiansky wants to merge 1 commit into
kafkiansky wants to merge 1 commit into
Conversation
Http2ConnectionProcessor::shutdown() queues GOAWAY and releases the active streams, but the socket is closed only in releaseStream() once the last stream is released. Closing a connection without active streams, e.g. an idle one, therefore only sent GOAWAY and left the socket open until the server closed it, which some servers (grpc-go) never do. The pool also kept waiting for such a connection to close, so the next request to the same authority could hang. Close the socket once the GOAWAY frame has been written.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Http2ConnectionProcessor::shutdown() queues GOAWAY and releases the active streams, but the socket is closed only in releaseStream() once the last stream is released. Closing a connection without active streams, e.g. an idle one, therefore only sent GOAWAY and left the socket open until the server closed it, which some servers (grpc-go) never do. The pool also kept waiting for such a connection to close, so the next request to the same authority could hang.
Close the socket once the GOAWAY frame has been written.