Keep reviews aligned with current pull request diffs - #211
Merged
Conversation
Use commit comparisons only to select files changed since the last review, then use their current pull request patches. Fall back to the full pull request diff when incremental comparison is unsafe. Validate review identity and hunk locations before creating comments. Propagate handler failures to GitHub Actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
After a rebase or force-push, comparing the previous reviewed commit with the new head can produce a diverged, repository-wide diff that no longer matches the pull request. Using those patches can omit relevant changes or create invalid inline comment positions. Review failures could also leave the workflow with a successful conclusion.
Validation
npm test -- --runInBand— 52 tests passednpm run buildgit diff HEAD^ HEAD --check