Fix junction deviation setting to handle decimal values - #361
Open
taligentx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thanks for the 6.x release! At least as of 6.0.2, junction deviation is incorrectly shown on the LCD as whole integers - for example, the EEPROM value of '0.010' is displayed on the LCD as '1'. The popup keypad for manual number entry is also incorrect - it is the keypad for whole unsigned integers and does not have the decimal button.
Requirements
LCD
Benefits
This PR includes an updated LCD config file for the '130_def_acceleration' screen to set the correct decimal places, popup keypad, and update the UI alignment for the 4-digit junction deviation value. Also updates the mainboard firmware to handle values to the thousandths place (as was in the 5.x firmware).
Configurations
n/a
Related Issues
n/a