Repository navigation
fix(scuttle): don't restart scuttle on switch (it deletes the Node) - #154
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deploying #153 on worker-1 (manual
nixos-upgrade, 2026-10-24 20:55 UTC) knocked it out of the cluster:scuttle.service, soswitch-to-configurationrestarted scuttle and left kubelet alone.uncordon error: nodes "worker-1" not found,Node worker-1 not found after 2 minutes; not recording a uid).This hits every worker tonight: their scheduled auto-upgrades (0N:40 UTC) will pull #153, change only scuttle, and delete each Node in turn.
Change
systemd.services.scuttle.restartIfChanged = false. A changed scuttle unit is no longer restarted by a switch; the new definition takes effect the next time kubelet restarts (scuttle is BindsTo kubelet) or on reboot.switch-to-configurationreadsX-RestartIfChangedfrom the new unit, so this also protects the switch that deploys it.Verification
nix evalof worker-2'sscuttle.serviceunit:X-RestartIfChanged=false,After=... containerd.service(from #153) still present. Not tested on a live node.