fix: keep distributed layer-slice HC on active tier - #631
Open
edoardolegnaro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I was tring to run DS4 on two nodes with 4 l40s gpus each.
The distributed deployment wasn't working, so I've asked GPT5.6 Sol to fix it and identified this minimal changes that were needed.
Below is output of codex after completion:
Summary
Errors fixed
active_tiercould still point at the preceding request's output tier when a new distributed hop wrote token embeddings or a remote hidden state.Reproduction
Tested with DeepSeek V4 Flash Q4 imatrix on a two-node CUDA pipeline. The coordinator owned layers
0:21; the worker owned22:outputand used multiple L40S GPUs.Against one long-lived
ds4-serverprocess:Restarting the server restored only the next first response.
Verification
After the fix, repeated and unrelated requests through the same server remained valid:
Consecutive non-streaming and streaming requests also completed through the OpenAI-compatible endpoint at a 1,048,576-token context.
Build and regression checks:
Results:
The sequential-request regression requires a sliced multi-node CUDA route and model artifacts, so no source-only test was added.
make testwas also attempted. The CUDA build node did not have the defaultds4flash.gguftest path, and the idle L40S validation node did not have/usr/local/cuda/bin/nvcc. The targeted CPU build, CUDA build, placement test, GPU cache test, and live distributed regression above completed successfully.