Repository navigation
Update standard bindings to Dear ImGui 1.93.0 - #104
Merged
Merged
Conversation
Collaborator
|
Maintenance review: this is not eligible for automatic low-risk merging. The 1.93.0 refresh removes the public ImDrawListFlags type, changes Style fields (for example AntiAliasedLinesUseTex to AntiAliasedLineEnds), and changes draw-list wrapper signatures by adding flags arguments. The generated output must remain generator-owned. The current-head push CI passed Linux, Windows, pinned V3 and advisory moving-dependency lanes; the fresh Windows setup check also passed. Keep this draft pending explicit approval of the API/ABI migration and downstream review. No release is proposed by this review. |
antono3
marked this pull request as ready for review
October 28, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the standard variant to Dear ImGui 1.93.0 from cimgui c4461a7eadbd17b6a6a8124a8abbf499aba6318d and cimplot c809ff29c84813fe1cdc8a0c069145ef2285f22a. Generated bindings/native files remain generator-owned. Prepares package 0.4.0 and a separately named v0.4.0-standard source release; the default docking variant remains unchanged. Migration notes describe the breaking API/ABI differences and require rebuilding the matching native library.
Consumer gate completed locally on Linux: v_vulkan_video plays the rotated bundled clip on a GTX 1060 with the actual Dear ImGui 1.93 demo overlay, working mouse input and resize/shutdown. All 737 decoded frames match FFmpeg byte-for-byte. Four player V test files pass. The GLFW/Vulkan demo, raw widget gallery, retained accessible gallery and ImPlot dashboard were visually inspected with interactive controls. Desktop render and shortcut regression suites pass. These are not Windows hardware-playback or physical mobile-device claims.
The workflow change also compares generated Git trees before committing/pushing and skips repeated PR edits/CI for identical updates. Six local-Git tests cover no-ops, real updates and lease races. A matching noise-only change is proposed for the default docking branch in #105.
Merge only after applicable current-head CI passes. Downstream source pins will be updated to the released standard tag after publication.