consolidate InfoViewer and PropEditor #6458
Conversation
| v.tablesOpt.addAll(opts.tablesOpt); | ||
| v.namespacesOpt.addAll(opts.namespacesOpt); |
There was a problem hiding this comment.
--get advertises the ability to accept --table and --namespace as well but only the plural tables and namespaces opts are copied.
There was a problem hiding this comment.
The singular --namespace / --table and plural --nampespaces / --tables are intentionally separate. They are intended to serve the different modes. The singular flags are meant to display a singular Zk scope for --set and --delete or default display, while the plural is used for filtering multi-scope ZK reports via --get.
There was a problem hiding this comment.
If the split is intentional then I agree tht we should keep them. In that case, I think the --get accepts the singular flags and silently ignores them. It might be better to reject the -t under --get and tell the user to use --tables. Hopefully im interpreting things correctly here
Closes issue #6428
Created a new
zk propscommand to consolidate ZooKeeper property inspection and editing. Both legacy commands are depreciated but remain and functional for backwards compatibility. The newzk propscore sub-commands operate as such: