[#2198] Fix pending sends count on rolled back send#2199
Open
mattrpav wants to merge 2 commits into
Open
Conversation
Contributor
|
@mattrpav - I have asked this several times before, can you please start adding actual information to your PRs and issues? You added a bunch of info to the test itself which explains the problem, some of that needs to be in the description so people can figure out what the point of the PR is without having to look at the test. |
cshannon
requested changes
Jul 8, 2026
cshannon
left a comment
cshannon
left a comment
Contributor
There was a problem hiding this comment.
LGTM, this is a good catch, just a couple minor tweaks that I noticed that could be done
mattrpav
force-pushed
the
amq-gh-2198-pending-sends-count
branch
from
049bb42 to
4081252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was uncovered while looking into a different issue.
The problem here is that pending sends counter (internal, not exposed) does not decrement on a rolled back producer transaction.