docs: warn on missing docker-start and document custom-image CMD pitfall - #13898
Open
mehrdadbn9 wants to merge 1 commit into
Open
docs: warn on missing docker-start and document custom-image CMD pitfall#13898mehrdadbn9 wants to merge 1 commit into
mehrdadbn9 wants to merge 1 commit into
Conversation
A custom image built from 'docker commit' of a shell session bakes the shell into CMD, replacing the official ['docker-start']. The entrypoint then falls through to 'exec "$@"' and the container exits 0 with no logs and no APISIX process. - emit a stderr warning when the first arg is not 'docker-start' so the silent failure is obvious - add an FAQ entry with the correct Dockerfile pattern (switch USER inside the Dockerfile instead of committing a shell) Refs apache#13775 Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com>
dosubot
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A custom image built from
docker commitof a shell session bakes the shell intoCMD, replacing the official["docker-start"]. The entrypoint then falls through toexec "$@"and the container exits 0 with no logs and no APISIX process (#13775).This PR:
/docker-entrypoint.shwhen the first argument is notdocker-start, so the silent failure is obvious instead of a mysterious exit 0.USERinside the Dockerfile instead of committing a shell session), plus the Kubernetescommand/argsoverride.Checklist
docker-startpathRefs #13775