[Arrow] Move parquet-variant-compute StructArrayBuilder to arrow-array - #10636
Open
cakeni wants to merge 1 commit into
Open
[Arrow] Move parquet-variant-compute StructArrayBuilder to arrow-array#10636cakeni wants to merge 1 commit into
cakeni wants to merge 1 commit into
Conversation
github-actions
Bot
added
arrow
cakeni
marked this pull request as ready for review
August 11, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
parquet-variant-computecontains a local helper for assembling aStructArrayfrom completed child arrays. The helper is generally useful Arrow functionality and should live inarrow-arrayinstead of being duplicated in a Variant-specific crate.What changes are included in this PR?
StructArrayBuilderfor completed child arrays toarrow-array.FieldRefvalues that retain metadata, and an optional top-level null buffer.parquet-variant-computeimplementation with the shared builder.Are these changes tested?
Yes.
cargo test -p arrow-array struct_array_builder(16 tests passed)cargo test -p parquet-variant-compute(347 unit tests and 13 doctests passed)Are there any user-facing changes?
Yes.
arrow-arrayexposes a new builder API for assemblingStructArrayvalues from completed children. Existing APIs are unchanged.