Skip to content

Fix download_files() in python-release.#39246

Open
shunping wants to merge 2 commits into
apache:masterfrom
shunping:fix-python-release-scripts
Open

Fix download_files() in python-release.#39246
shunping wants to merge 2 commits into
apache:masterfrom
shunping:fix-python-release-scripts

Conversation

@shunping

@shunping shunping commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes the broken scripts in python release automation.

  • Update download_files() in python_release_automation_utils.sh to support Python 3.10 - 3.14.
  • Update manylinux wheel filename pattern for newer release artifacts.
  • Pass -e robots=off to wget to avoid robots.txt blocking artifact downloads.

Verified that the files can be downloaded successfully with the updated download_files() using the following script:

set -e
set -v

SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
source "$SCRIPT_DIR/python_release_automation_utils.sh"

export VERSION=2.74.0
export RC_STAGING_URL="https://dist.apache.org/repos/dist/dev/beam/$VERSION/python"
for version in 3.10 3.11 3.12 3.13 3.14
do
  download_files "wheel" "python${version}"
  download_files "tar" "python${version}"
done

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Python release automation scripts to ensure compatibility with recent Python versions and improve the reliability of the artifact download process. By adjusting the wheel naming patterns and configuring wget to ignore robots.txt, the scripts are now better equipped to handle modern release environments.

Highlights

  • Python Version Support: Updated the download_files() function to support Python versions 3.10 through 3.14.
  • Wheel Pattern Update: Modified the manylinux wheel filename patterns to accommodate newer release artifact naming conventions.
  • Download Reliability: Added the -e robots=off flag to wget commands to prevent robots.txt from blocking artifact downloads.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the build label Jul 8, 2026
@shunping

shunping commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

r: @Amar3tto

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Python release automation utilities to support Python versions 3.10 through 3.14, updates the wheel filename patterns, adds -e robots=off to wget commands, and corrects the source distribution tarball filename. The review feedback suggests refactoring the repetitive Python version conditional block using bash parameter expansion to improve maintainability, and recommends wrapping the $RC_STAGING_URL variable in double quotes within the wget commands to prevent potential word splitting or glob expansion issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread release/src/main/python-release/python_release_automation_utils.sh
Comment thread release/src/main/python-release/python_release_automation_utils.sh Outdated
Comment thread release/src/main/python-release/python_release_automation_utils.sh Outdated
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping shunping requested a review from Amar3tto July 8, 2026 14:49
@shunping

shunping commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

The failed workflows are currently failing on the master branch as well, so they are unrelated to the changes introduced in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant