Skip to content

FastEnum: implement __str__ and __repr__ to match StrEnum for docs reproducibility #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juergbi merged 2 commits into from
Jul 14, 2026
+14 −14
Merged

FastEnum: implement __str__ and __repr__ to match StrEnum for docs reproducibility #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
153ea04
FastEnum: update __repr__ and __str__ to behave like StrEnum
tti0 Jul 11, 2026
7967a16
cli: stringify FastEnum's passed as Click defaults
tti0 Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/buildstream/_frontend/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def build(
@click.option(
"--deps",
"-d",
default=_PipelineSelection.ALL,
default=str(_PipelineSelection.ALL),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -814,7 +814,7 @@ def source():
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -887,7 +887,7 @@ def source_fetch(app, elements, deps, except_, source_remotes, ignore_project_so
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -960,7 +960,7 @@ def source_push(app, elements, deps, except_, source_remotes, ignore_project_sou
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -1015,7 +1015,7 @@ def source_track(app, elements, deps, except_, cross_junctions):
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -1296,7 +1296,7 @@ def artifact():
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -1339,7 +1339,7 @@ def artifact_show(app, deps, artifact_remotes, ignore_project_artifact_remotes,
@click.option(
"--deps",
"-d",
default=_PipelineSelection.RUN,
default=str(_PipelineSelection.RUN),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -1464,7 +1464,7 @@ def artifact_checkout(
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -1533,7 +1533,7 @@ def artifact_pull(app, deps, artifact_remotes, ignore_project_artifact_remotes,
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down Expand Up @@ -1673,7 +1673,7 @@ def artifact_list_contents(app, artifacts, long_):
@click.option(
"--deps",
"-d",
default=_PipelineSelection.NONE,
default=str(_PipelineSelection.NONE),
show_default=True,
type=FastEnumType(
_PipelineSelection,
Expand Down
8 changes: 4 additions & 4 deletions src/buildstream/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,14 @@ def __hash__(self):
return hash(id(self))

def __str__(self):
return "{}.{}".format(self.__class__.__name__, self.name)
return str(self.value)

def __reduce__(self):
return self.__class__, (self.value,)

def __repr__(self):
return "<{}.{}: {}>".format(self.__class__.__name__, self.name, self.value)


class CoreWarnings:
"""CoreWarnings()
Expand Down Expand Up @@ -307,9 +310,6 @@ class _PipelineSelection(FastEnum):
# including the targets
RUN = "run"

def __str__(self):
return str(self.value)


# _ProjectInformation()
#
Expand Down
Loading