Element: Remove unused & deprecated node_subst methods#2154
Open
nathanwilliams-ct wants to merge 1 commit into
Open
Element: Remove unused & deprecated node_subst methods#2154nathanwilliams-ct wants to merge 1 commit into
nathanwilliams-ct wants to merge 1 commit into
Conversation
These deprecation notices were introduced into the codebase 6 years ago (April 16th, 2020 5:56 PM) There have been many Buildstream versions since then, a search in the Buildstream codebase shows they are unused, so it's about time they are removed.
nathanwilliams-ct
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
July 17, 2026 13:15
Contributor
|
Unfortunately, this is part of the public plugin API where we guarantee stability across stable releases. We failed to remove it before 2.0. And some plugins in buildstream-plugins-community are even still using it, should probably fix that. |
|
So this PR is a candidate for 3.0 assuming we sort the buildstream community plugins for it. Do you know if there's an issue to track this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These deprecation notices were introduced into the codebase 6 years ago (April 16th, 2020 5:56 PM) e5ed02d
There have been many Buildstream versions since then, a search in the Buildstream codebase shows they are unused, so it's about time they are removed.