fix: guard LRUCache against non-positive capacity - #1749
Merged
hsluoyz merged 3 commits intoAug 21, 2026
Conversation
NewLRUCache and NewSyncLRUCache are exported, but calling Put on a cache created with a non-positive capacity panicked with a nil pointer dereference: the eviction path removes cache.tail.prev, which on an empty list is the head sentinel whose prev pointer is nil. Return early from Put when capacity is non-positive, since such a cache holds nothing. Add a regression test that fails (panics) before this change and passes after.
nikolauspschuetz
marked this pull request as ready for review
August 16, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.