fix: copy sets before sorting in SetEquals, SetEqualsInt and Set2DEquals - #1753
Open
lenamonj wants to merge 1 commit into
Open
fix: copy sets before sorting in SetEquals, SetEqualsInt and Set2DEquals#1753lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1752.
SetEquals,SetEqualsIntandSet2DEqualssorted their arguments in place. BecauseGetPermissionsForUserreturns the model's live policy rows, usingSet2DEqualson its result reordered each stored rule's fields (p, zoe, data1, readbecamedata1, read, zoe) and flipped subsequentEnforcecalls from allow to deny. Full reproduction and output are in the issue.This change sorts copies instead: the outer slices in all three helpers, and in
Set2DEqualsthe inner rows as well, since reordering a row's fields is the mutation that corrupts a policy rule. Comparison semantics are unchanged.TestSetComparisonsDoNotModifyArgumentscovers all three helpers and fails on master before this change.go test -count=1 ./...is green with it applied.