Make domainid optional in assignVirtualMachine

[winterhazel]

Description

assignVirtualMachine demands providing a domainid, even though there are situations in which it is not required, such as when moving an instance to a project using projectid. This patch removes this restriction.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

• I verified that it was possible to assign resources via the UI for both accounts and projects
• I verified that it was possible to assign resources via the API by providing only the projectid and virtualmachineid parameters
• I verified that it was possible to assign resources via the API by providing only the account, domainid, and virtualmachineid parameters
• I verified that when both projectid and domainid are provided, domainid is ignored and the VM is moved to the project

[winterhazel]

@blueorangutan package

[blueorangutan]

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17973

[winterhazel]

@blueorangutan package

[blueorangutan]

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17974

[DaanHoogland]

03:57:02 ERROR: We couldn't grab the PR author. Something went wrong querying the GitHub API.

@winterhazel , I think we are hitting one of our limits here. I’ll try some more in the backend.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17984

[JoaoJandre]

CLGTM

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18284

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

code lgtm

[weizhouapache]

@winterhazel
can you explore if the use case can be covered by smoke test test_assign_vm.py ?

[blueorangutan]

[SF] Trillian test result (tid-16360)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51824 seconds
Marvin logs: [archive removed]
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[winterhazel]

@winterhazel can you explore if the use case can be covered by smoke test test_assign_vm.py ?

@weizhouapache it is not, this test does not check assignment to projects currently.

[sudo87]

lgtm, tested it as well