fix(ui): validate OOBM is enabled before allowing HA on KVM hosts (#13605) by Chinmay048 · Pull Request #13647 · apache/cloudstack

Chinmay048 · 2026-07-19T18:20:08Z

Description

This PR updates the Vue UI infrastructure configuration (hosts.js) to validate that Out-of-Band Management (OOBM) is active and enabled before allowing administrators to configure or enable High Availability (HA) on KVM hosts. If OOBM is not enabled on a KVM host, the HA action buttons are cleanly hidden to prevent invalid configurations.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

Verified in the Vue UI that for KVM hosts where record.outofbandmanagement.enabled is false or undefined, the "Configure HA" and "Enable HA" action buttons are properly hidden.
Verified that KVM hosts with active OOBM configurations (and Simulator hosts) continue to display the HA action buttons normally.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

kiranchavala · 2026-07-20T04:31:43Z

@blueorangutan ui

codecov · 2026-07-20T04:40:24Z

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.20%. Comparing base (549daae) to head (9cdb779).
⚠️ Report is 29 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...nagement/DisableOutOfBandManagementForHostCmd.java	0.00%	6 Missing ⚠️
...ck/api/command/admin/ha/ConfigureHAForHostCmd.java	0.00%	3 Missing ⚠️
...stack/api/command/admin/ha/EnableHAForHostCmd.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #13647      +/-   ##
============================================
+ Coverage     16.26%   17.20%   +0.94%     
- Complexity    13434    13574     +140     
============================================
  Files          5667     5264     -403     
  Lines        500731   468353   -32378     
  Branches      60803    55012    -5791     
============================================
- Hits          81455    80596     -859     
+ Misses       410172   378748   -31424     
+ Partials       9104     9009      -95

Flag	Coverage Δ
uitests	`?`
unittests	`17.20% <0.00%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kiranchavala · 2026-07-20T12:25:05Z

@blueorangutan package

kiranchavala · 2026-07-21T04:43:51Z

cc @weizhouapache @winterhazel

Consider this UI improvement for the 4.23 release

kiranchavala

Looks good

Message when user tries to Enable OOBM

Message when user tries to Enable HA

Wondering if we should Disable HA when OOBM is also disabled

cc @sureshanaparti

kiranchavala · 2026-07-21T09:24:38Z

@Chinmay048 when admin clicks on Disable OOBM ,cloudstack should thrown a pop-up saying that to Disable HA First

Only if the HA is disabled we should allow to disable the OOBM

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Chinmay048 · 2026-07-21T10:02:20Z

Thanks for the review and feedback @kiranchavala! That makes complete sense to guard the teardown flow as well.

I am working on updating the Disable OOBM action right now so that if a host currently has High Availability (HA) enabled, the UI will intercept the action and display a warning pop-up instructing the admin to disable HA first before allowing OOBM to be turned off. Will push the commit to this PR shortly!

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

kiranchavala · 2026-07-21T13:19:01Z

@blueorangutan package

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

winterhazel · 2026-07-21T16:47:35Z

cc @weizhouapache @winterhazel

Consider this UI improvement for the 4.23 release

@kiranchavala I intend to cut a RC2 tomorrow around 2026-07-22 16:00 GMT. I will include this patch if it is ready by then.

This issue is not major to block 4.23 RC2, as it does not prevent any operations via the UI or result in any bugs. The patch needs some adjustments as well (I'll send some reviews later).

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

ui/src/components/view/ActionButton.vue:181

execAction references this.item, but ActionButton doesn't define an item prop/data/computed. This means record will never fall back to the clicked row item and will also trigger Vue warnings about accessing undefined instance properties. Prefer deriving record from resource and assigning action.resource from the same value to keep downstream action handling consistent.

    execAction (action) {
      action.resource = this.resource
      const record = this.resource || this.item
      if (action?.api === 'disableOutOfBandManagementForHost' && (record?.hostha?.haenable === true || record?.hastate === 'Enabled')) {

ui/src/components/view/ListView.vue:658

The <template v-if="column.key === 'clustername'"> line lost its indentation, which makes this block inconsistent with the surrounding template and may violate Vue/ESLint formatting rules.

<template v-if="column.key === 'clustername'">

ui/src/components/view/ListView.vue:696

The updated account-column rendering has two functional regressions: (1) for PrjAcct-* values outside /quotasummary, nothing is rendered (no v-else fallback), leaving the cell blank; (2) the /quotasummary link is created even when record.accountid is missing and without the previous 404-route guard, which can produce links to invalid routes.

        <template v-if="text">
          <template v-if="!text.startsWith('PrjAcct-')">
            <router-link
              v-if="$route.path.startsWith('/quotasummary')"
              :to="{ path: `${$route.path}/${record.accountid}` }">{{ text }}</router-link>

winterhazel

@Chinmay048 I left a few comments. I think this can go into 4.20.4 too, could you check and rebase into branch 4.20 if that is indeed the case?

Also, it would be nice to add the same checks to the enableHAForHost, configureHAForHost and disableOutOfBandManagementForHost APIs.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Chinmay048 · 2026-07-22T13:53:03Z

I have pushed a new update to enforce the backend API validation. The DisableOutOfBandManagementForHostCmd now correctly checks haConfigManager.listHAResources to prevent disabling OOBM if HA is active on a KVM host. All local Checkstyle and compilation errors have been resolved. Waiting on the CI simulator tests to complete!

DaanHoogland · 2026-08-10T13:59:19Z

@blueorangutan package

DaanHoogland · 2026-08-10T16:33:10Z

@blueorangutan test

kiranchavala · 2026-08-11T07:45:33Z

@blueorangutan ui

kiranchavala · 2026-08-14T04:44:10Z

@Chinmay048 @sureshanaparti

can you take a look at the smoke test failures related to host ha

Chinmay048 · 2026-08-14T13:56:03Z

@kiranchavala I have updated the setUp method in test_hostha_kvm.py to globally enable OOBM before the HA tests run. Could you please kick off the Trillian smoke tests again to verify?

DaanHoogland · 2026-08-31T14:54:38Z

@blueorangutan shutup

DaanHoogland · 2026-08-31T14:57:37Z

@blueorangutan package

blueorangutan · 2026-08-31T14:58:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-08-31T15:52:22Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19032

DaanHoogland · 2026-09-01T07:24:29Z

@blueorangutan test

blueorangutan · 2026-09-01T07:26:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-09-01T22:57:59Z

[SF] Trillian test result (tid-16858)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52378 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13647-t16858-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_disable_oobm_ha_state_ineligible	`Error`	15.55	test_hostha_kvm.py
test_hostha_configure_default_driver	`Error`	0.34	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled	`Error`	0.34	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	`Error`	0.33	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	0.38	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	0.32	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	0.33	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	0.35	test_hostha_kvm.py
test_remove_ha_provider_not_possible	`Error`	0.34	test_hostha_kvm.py

DaanHoogland · 2026-09-02T15:22:09Z

@Chinmay048 I would think that the hostha errors are related to the change. can you check

[SF] Trillian test result (tid-16858) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 52378 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13647-t16858-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_disable_oobm_ha_state_ineligible Error 15.55 test_hostha_kvm.py
test_hostha_configure_default_driver Error 0.34 test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled Error 0.34 test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected Error 0.33 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 0.38 test_hostha_kvm.py
test_hostha_kvm_host_degraded Error 0.32 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 0.33 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 0.35 test_hostha_kvm.py
test_remove_ha_provider_not_possible Error 0.34 test_hostha_kvm.py

Chinmay048 · 2026-09-03T12:17:34Z

The new backend validation was blocking the tests because the legacy test fixtures were calling configureHAForHost without first provisioning an OOBM interface. I have injected a dummy OOBM setup method into the execution flow for both the KVM and Simulator test suites.

DaanHoogland · 2026-09-05T14:41:48Z

@winterhazel , can you check if your requests for change are addressed to satisfaction?

Copilot AI lite review requested due to automatic review settings July 19, 2026 18:20

boring-cyborg Bot added the component:UI label Jul 19, 2026

Copilot AI reviewed Jul 19, 2026

kiranchavala reviewed Jul 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 21, 2026 10:01

Copilot AI reviewed Jul 21, 2026

Chinmay048 force-pushed the fix-13605-kvm-ha-oobm branch from 586999a to 068213b Compare July 21, 2026 10:36

Copilot AI review requested due to automatic review settings July 21, 2026 10:36

Copilot AI reviewed Jul 21, 2026

kiranchavala requested a review from Copilot July 21, 2026 13:18

Copilot started reviewing on behalf of kiranchavala July 21, 2026 13:18 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Damans227 reviewed Jul 21, 2026

View reviewed changes

Comment thread ui/src/components/view/ListView.vue Outdated

Comment thread ui/src/components/view/ActionButton.vue Outdated

DaanHoogland requested a review from Copilot July 21, 2026 19:25

Copilot started reviewing on behalf of DaanHoogland July 21, 2026 19:26 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

winterhazel requested changes Jul 21, 2026

View reviewed changes

Comment thread ui/src/components/view/ListView.vue

Comment thread ui/src/components/view/ActionButton.vue Outdated

Comment thread ui/src/config/section/infra/hosts.js Outdated

Comment thread ui/src/config/section/infra/hosts.js Outdated

Chinmay048 force-pushed the fix-13605-kvm-ha-oobm branch from 068213b to 4c78cd7 Compare July 22, 2026 13:46

Copilot AI review requested due to automatic review settings July 22, 2026 13:46

boring-cyborg Bot added the component:api label Jul 22, 2026

Copilot AI reviewed Jul 22, 2026

github-actions Bot removed the status:has-conflicts label Aug 8, 2026

DaanHoogland added this to CloudStack Testing Aug 10, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 10, 2026

DaanHoogland added this to the 4.20.4 milestone Aug 10, 2026

DaanHoogland requested a review from winterhazel August 10, 2026 16:32

test: ensure OOBM is enabled in HA KVM test setup

1b297c3

boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Aug 14, 2026

DaanHoogland moved this from Backlog to Ready in CloudStack Testing Aug 31, 2026

DaanHoogland assigned borisstoyanov Sep 1, 2026

test: inject dummy OOBM fixtures to resolve hostha validation failures

5c37fa3

DaanHoogland reviewed Sep 3, 2026

View reviewed changes

Comment thread test/integration/smoke/test_hostha_kvm.py Outdated

boring-cyborg Bot added the component:marvin label Sep 3, 2026

test: refactor setupDummyOOBM into parent class to resolve DRY violation

9cdb779

Chinmay048 force-pushed the fix-13605-kvm-ha-oobm branch from 5577e75 to 9cdb779 Compare September 5, 2026 11:46

Uh oh!

Conversation

Chinmay048 commented Jul 19, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Jul 20, 2026

Uh oh!

codecov Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kiranchavala commented Jul 20, 2026

Uh oh!

kiranchavala commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Chinmay048 commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

winterhazel commented Jul 21, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

winterhazel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Chinmay048 commented Jul 22, 2026

Uh oh!

DaanHoogland commented Aug 10, 2026

Uh oh!

DaanHoogland commented Aug 10, 2026

Uh oh!

kiranchavala commented Aug 11, 2026

Uh oh!

kiranchavala commented Aug 14, 2026

Uh oh!

Chinmay048 commented Aug 14, 2026

Uh oh!

DaanHoogland commented Aug 31, 2026

codecov Bot commented Jul 20, 2026 •

edited

Loading

kiranchavala commented Jul 21, 2026 •

edited

Loading

kiranchavala commented Jul 21, 2026 •

edited

Loading