server: apply the restored volume max IOPS to the max IOPS field - #14024
Open
nagaboinaramgopal wants to merge 1 commit into
Open
server: apply the restored volume max IOPS to the max IOPS field#14024nagaboinaramgopal wants to merge 1 commit into
nagaboinaramgopal wants to merge 1 commit into
Conversation
getRootVolumeSizeForVmRestore set the requested max IOPS onto the min IOPS field, overwriting the min value and never applying the max, so restoring a VM with an IOPS spec silently corrupted the volume QoS. Set the max IOPS on the max IOPS field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a VM is restored,
getRootVolumeSizeForVmRestorereads the requested minand max IOPS from the volume details, but a copy-paste slip assigned the max
IOPS value into the min IOPS field:
So
setMinIopswas called twice andsetMaxIopswas never called. The resultis that restoring a VM silently drops the volume's max IOPS QoS setting and
overwrites min IOPS with the max value. Fixed by assigning the parsed max IOPS
to
setMaxIops.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Added a unit test that restores a volume with min IOPS 500 and max IOPS 2000
and asserts each field holds its own value. Also built the standard packages
and deployed on a KVM advanced zone.