engine-schema: upgrade path for 4.24.0 - #14033
Conversation
Adds a 4.23.0 to 4.24.0 upgrade path. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14033 +/- ##
============================================
- Coverage 19.73% 19.73% -0.01%
+ Complexity 19960 19957 -3
============================================
Files 6371 6372 +1
Lines 575784 575792 +8
Branches 70478 70478
============================================
- Hits 113659 113655 -4
- Misses 449772 449785 +13
+ Partials 12353 12352 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19055 |
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Adds the database upgrade plumbing for a 4.23.0.0 → 4.24.0.0 engine schema upgrade.
Changes:
- Adds new (currently comment-only) schema upgrade and cleanup SQL scripts for 4.23.0.0 → 4.24.0.0.
- Introduces
Upgrade42300to42400Java upgrade class to define the version range and target version. - Registers the new upgrade step in
DatabaseUpgradeChecker’s upgrade path chain.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| engine/schema/src/main/resources/META-INF/db/schema-42300to42400.sql | Adds the 4.23.0.0 → 4.24.0.0 schema upgrade script file (currently header/comments only). |
| engine/schema/src/main/resources/META-INF/db/schema-42300to42400-cleanup.sql | Adds the corresponding cleanup script file (currently header/comments only). |
| engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42300to42400.java | Adds the Java upgrade step declaring version range and upgraded version. |
| engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java | Wires the new upgrade step into the upgrader chain. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| --; | ||
| -- Schema upgrade cleanup from 4.23.0.0 to 4.24.0.0 | ||
| --; |
|
|
||
| --; | ||
| -- Schema upgrade from 4.23.0.0 to 4.24.0.0 | ||
| --; |
DaanHoogland
left a comment
There was a problem hiding this comment.
let’s do #14033 instead
|
maybe this can go on top of that one |
Description
Adds a 4.23.0 to 4.24.0 upgrade path.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?