Skip to content

engine-schema: upgrade path for 4.24.0 - #14033

Draft
shwstppr wants to merge 1 commit into
apache:mainfrom
shapeblue:upgradepath-424
Draft

engine-schema: upgrade path for 4.24.0#14033
shwstppr wants to merge 1 commit into
apache:mainfrom
shapeblue:upgradepath-424

Conversation

@shwstppr

@shwstppr shwstppr commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a 4.23.0 to 4.24.0 upgrade path.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Adds a 4.23.0 to 4.24.0 upgrade path.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

shwstppr commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.73%. Comparing base (8fb3ad4) to head (bf8ced5).

Files with missing lines Patch % Lines
...ava/com/cloud/upgrade/dao/Upgrade42300to42400.java 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14033      +/-   ##
============================================
- Coverage     19.73%   19.73%   -0.01%     
+ Complexity    19960    19957       -3     
============================================
  Files          6371     6372       +1     
  Lines        575784   575792       +8     
  Branches      70478    70478              
============================================
- Hits         113659   113655       -4     
- Misses       449772   449785      +13     
+ Partials      12353    12352       -1     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 21.01% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@shwstppr
shwstppr requested a lite review from Copilot September 2, 2026 07:27
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19055

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Adds the database upgrade plumbing for a 4.23.0.0 → 4.24.0.0 engine schema upgrade.

Changes:

  • Adds new (currently comment-only) schema upgrade and cleanup SQL scripts for 4.23.0.0 → 4.24.0.0.
  • Introduces Upgrade42300to42400 Java upgrade class to define the version range and target version.
  • Registers the new upgrade step in DatabaseUpgradeChecker’s upgrade path chain.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
engine/schema/src/main/resources/META-INF/db/schema-42300to42400.sql Adds the 4.23.0.0 → 4.24.0.0 schema upgrade script file (currently header/comments only).
engine/schema/src/main/resources/META-INF/db/schema-42300to42400-cleanup.sql Adds the corresponding cleanup script file (currently header/comments only).
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42300to42400.java Adds the Java upgrade step declaring version range and upgraded version.
engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java Wires the new upgrade step into the upgrader chain.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.


--;
-- Schema upgrade cleanup from 4.23.0.0 to 4.24.0.0
--;

--;
-- Schema upgrade from 4.23.0.0 to 4.24.0.0
--;

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let’s do #14033 instead

@DaanHoogland

Copy link
Copy Markdown
Contributor

maybe this can go on top of that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants