Skip to content

Fix remaining sonarcloud warnings - #731

Merged
Claudenw merged 3 commits into
masterfrom
fix/sonarCloudWarnings
Sep 20, 2026
Merged

Claudenw merged 3 commits into
masterfrom
fix/sonarCloudWarnings

Conversation

@ottlinger

@ottlinger ottlinger commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Followup of #730:

  • replace assertion in test as suggested by sonar analysis
  • NOSONAR ThreadLocal warnings to call remove as classes are handed to other classes in RAT

Rule java:S5164
"ThreadLocal" variables should be cleaned up when no longer used

Rule does not apply in these classes and can be silenced.
@sonarqubecloud

Copy link
Copy Markdown

@ottlinger
ottlinger marked this pull request as ready for review September 19, 2026 18:01
@ottlinger
ottlinger requested a review from Claudenw September 19, 2026 18:01

@Claudenw Claudenw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Claudenw
Claudenw merged commit 6842b82 into master Sep 20, 2026
15 checks passed
@Claudenw
Claudenw deleted the fix/sonarCloudWarnings branch September 20, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants