Repository navigation
fix: allow standalone scheduler to use a session-configured partition slicing resolver - #2886
Open
vikrantmehta123 wants to merge 2 commits into
Open
vikrantmehta123 wants to merge 2 commits into
vikrantmehta123 wants to merge 2 commits into
Conversation
andygrove
approved these changes
Nov 17, 2026
andygrove
left a comment
Member
There was a problem hiding this comment.
Thanks @vikrantmehta123, this looks good. Reading the resolver from the session config next to the codec is a clean fit, and the upgrade note is clear. I added the api-change label since the note calls out the two new SessionConfigExt methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2839 .
Rationale for this change
Standalone setup creates its own
SchedulerConfig, leaving no way to supply aPartitionSliceableResolver. Custom plan nodes that require partition slicing therefore cannot run when their stages are split between tasks. The issue suggested two options. I have chosen the option of registering resolver next to the codec.What changes are included in this PR?
SessionConfigExt, following the existing codec extension pattern.SchedulerConfigduring standalone setup.Note: AI helped me identify that there are docs to be changed. AI also helped me come up with the integration test. I have read and understood both these changes, and they looked reasonable to me.
Are there any user-facing changes?
Yes, users can optionally register a resolver in standalone mode. The
SessionConfigExtgets two more methods. This is documented in the upgrade guide.