[Improvement-18666] Support field sorting on workflow definition list - #18658
chovy-3012 wants to merge 3 commits into
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
5d931fb to
2af74f9
Compare
Thanks for the pointer — I've aligned this PR with the Pull Request Notice |
2af74f9 to
8ab05bf
Compare
8ab05bf to
ab63f72
Compare
SbloodyS
left a comment
There was a problem hiding this comment.
WorkflowDefinitionMapper.xml handles the field and direction fallbacks independently. Consequently, sortField=foo&sortOrder=asc produces update_time asc, id asc, whereas #18666 specifies update_time desc for unrecognized fields. Please apply the complete default ordering when sortField is invalid and cover this parameter combination.
Thanks. The field and direction were two independent blocks, so sortField=foo&sortOrder=asc fell back to update_time for the field but still honored asc for the direction, yielding update_time asc, id asc instead of the complete default. |
Was this PR generated or assisted by AI?
NO
Purpose of the pull request
Close #18666
Add field sorting by name / createTime / updateTime to
the workflow definition list. Allowing users to sort by name, createTime, or updateTime by clicking the corresponding column header.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md