Skip to content

[Improvement-18666] Support field sorting on workflow definition list - #18658

Open
chovy-3012 wants to merge 3 commits into
apache:devfrom
chovy-3012:feature_workflow_definition_field_sort
Open

chovy-3012 wants to merge 3 commits into
apache:devfrom
chovy-3012:feature_workflow_definition_field_sort

Conversation

@chovy-3012

@chovy-3012 chovy-3012 commented Sep 21, 2026 •

Copy link
Copy Markdown

Was this PR generated or assisted by AI?

NO

Purpose of the pull request

Close #18666
Add field sorting by name / createTime / updateTime to
the workflow definition list. Allowing users to sort by name, createTime, or updateTime by clicking the corresponding column header.

Brief change log

  • Add sortField/sortOrder params to the workflow definition list query

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

./mvnw -pl dolphinscheduler-api -am test -Dtest='WorkflowDefinitionServiceTest,WorkflowDefinitionControllerTest' \
    -Djacoco.skip=true -Denforcer.skip=true -Dsurefire.failIfNoSpecifiedTests=false -q

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@boring-cyborg

boring-cyborg Bot commented Sep 21, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@github-actions github-actions Bot added UI ui and front end related backend test labels Sep 21, 2026
@SbloodyS SbloodyS added the first time contributor First-time contributor label Sep 24, 2026

@SbloodyS SbloodyS left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the pull request notice.

@chovy-3012 chovy-3012 changed the title [Improvement][API&DAO&UI] Support field sorting on workflow definitio… [Improvement-18666] Support field sorting on workflow definition list Sep 28, 2026
@chovy-3012
chovy-3012 force-pushed the feature_workflow_definition_field_sort branch from 5d931fb to 2af74f9 Compare September 28, 2026 13:07
@chovy-3012

Copy link
Copy Markdown
Author

Please follow the pull request notice.

Thanks for the pointer — I've aligned this PR with the Pull Request Notice

@chovy-3012
chovy-3012 force-pushed the feature_workflow_definition_field_sort branch from 2af74f9 to 8ab05bf Compare September 28, 2026 13:21
@chovy-3012
chovy-3012 force-pushed the feature_workflow_definition_field_sort branch from 8ab05bf to ab63f72 Compare September 29, 2026 01:14
@SbloodyS SbloodyS added this to the 3.5.0 milestone Sep 29, 2026

@SbloodyS SbloodyS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WorkflowDefinitionMapper.xml handles the field and direction fallbacks independently. Consequently, sortField=foo&sortOrder=asc produces update_time asc, id asc, whereas #18666 specifies update_time desc for unrecognized fields. Please apply the complete default ordering when sortField is invalid and cover this parameter combination.

@chovy-3012

Copy link
Copy Markdown
Author

WorkflowDefinitionMapper.xml handles the field and direction fallbacks independently. Consequently, sortField=foo&sortOrder=asc produces update_time asc, id asc, whereas #18666 specifies update_time desc for unrecognized fields. Please apply the complete default ordering when sortField is invalid and cover this parameter combination.

Thanks. The field and direction were two independent blocks, so sortField=foo&sortOrder=asc fell back to update_time for the field but still honored asc for the direction, yielding update_time asc, id asc instead of the complete default.
Fixed by merging them into a single nested

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend first time contributor First-time contributor test UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][API] Support field sorting on workflow definition list

2 participants