Fix schema change docs: NOT NULL to NULL is supported - #4107
Open
ixzc wants to merge 2 commits into
Open
Conversation
Clarify that changing NOT NULL to NULL is supported via heavyweight Schema Change, while NULL to NOT NULL is not. Remove the incorrect blanket statement that all Nullable attribute changes are unsupported, which contradicted the page examples and Doris behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply the same NOT NULL to NULL clarification to 3.x English and Chinese schema-change pages, matching the updates already made for dev/current and 4.x. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Column.checkSchemaChangeAllowed()).MODIFY COLUMN ... NULLexample and list NOT NULL → NULL under heavyweight Schema Change operations.Motivation
The current Limitations table states:
This is misleading for operators changing columns to nullable (e.g.
MODIFY COLUMN col INT NULL), which triggers a heavyweight Schema Change job and is covered by regression tests (test_alter_table_column_nullable.groovy).Files changed
docs/table-design/schema-change.md(dev/current, EN)i18n/zh-CN/.../current/table-design/schema-change.md(dev/current, ZH)versioned_docs/version-4.x/table-design/schema-change.md(4.x, EN)i18n/zh-CN/.../version-4.x/table-design/schema-change.md(4.x, ZH)Test plan
fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java(checkSchemaChangeAllowed)MODIFY COLUMN col3 varchar(50) KEY NULLregression-test/suites/schema_change_p0/test_alter_table_column_nullable.groovyMade with Cursor