[alerter]bugfix: fix Gotify default webhook URL - #4350
Open
paultanay wants to merge 4 commits into
Open
Conversation
paultanay
marked this pull request as ready for review
August 24, 2026 18:18
Contributor
Author
|
ready for review @Aias00 could you please run the ci once, thanks... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Fixes #4349
This PR fixes the fallback default Gotify webhook URL in
AlerterProperties.GotifyAlertNotifyHandlerImplbuilds the webhook URL withString.format(...), but the Java fallback default was missing the%splaceholder. When that fallback value is used, the receiver Gotify token is ignored and the generated request URL does not include the token.This change makes the Java fallback default consistent with the configured value in
application.yml.Changes
%stoken placeholder to the default Gotify webhook URL.Test
mvn -pl hertzbeat-alerter -Dtest=GotifyAlertNotifyHandlerImplTest test