[bugfix] preserve special characters in promql queries - #4376
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
PromQL expressions are inserted directly into query parameters, leaving
+and&unescaped. The server decodes addition operators and regex quantifiers as spaces, and an ampersand in a label value splits the expression into another parameter. For example,sum(up{job=~"api.+",label="a&b=50%"}) + 1arrives truncated and altered.Encode the expression as a URI template value in
executeand both instant and rangequeryrequests. The regression captures the URI from each actual executor path and checks the server-decoded parameters, including the range bounds and step.Validation on Windows with Java 25: all 10 query-executor tests pass, including the three new regressions that fail before the fix. Maven Checkstyle and
git diff --checkpass. The full warehouse suite and a live Prometheus server were not run.Checklist
Add or update API
No API changes.