Repository navigation
Fix APR-util version tests under APR 2.x - #1047
Merged
Merged
Conversation
notroj
force-pushed
the
apu-version-tests
branch
from
November 16, 2026 21:36
88a4159 to
403f7fe
Compare
APR and APR-util versions on trunk and 2.4.x. [skip ci] Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* modules/aaa/mod_authn_dbm.c, modules/aaa/mod_authz_dbm.c, modules/cache/mod_socache_dbm.c, modules/mappers/mod_rewrite.c, modules/proxy/mod_proxy_express.c: Include apu_version.h unconditionally. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
matching the apr-config check. Update the APR-util comment to match the version tested. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
notroj
force-pushed
the
apu-version-tests
branch
from
November 16, 2026 21:37
403f7fe to
4f3969e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several modules include
apu_version.honly under#if !APR_VERSION_AT_LEAST(2,0,0)and then testAPU_MAJOR_VERSION > 1. With APR 2.x the macro is then undefined, the test is false, and the pre-1.7apr_dbm_open()code is compiled instead of theapr_dbm_get_driver()path. APR trunk ships anapu_version.hwhich maps theAPU_*_VERSIONmacros to the APR ones, so the include is now unconditional inmod_authn_dbm,mod_authz_dbm,mod_socache_dbm,mod_rewriteandmod_proxy_express.configure.innow requires APR 1.6 in the compile-time check as well, matching theapr-configcheck.AGENTS.mdgains a section on testing APR-util versions and the minimum versions on trunk and 2.4.x.mod_autht_jwtis deliberately left alone. It testsAPU_MAJOR_VERSIONbefore including any header, so it is always built as a stub, and the code behind the test no longer compiles.🤖 Generated with Claude Code