fix off-by-one buffer overflow in proxy_send_dir_filter#677
Open
arshsmith1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proxy_send_dir_filter accumulates each FTP listing line into a fixed MAX_STRING_LEN buffer, and an over-long line from the backend fills it to the last byte with its newline truncated, so the ls -s1 fallback branch then strcat()s a newline two bytes past the array. A bare-LF line trips a matching underflow: the trailing-newline strip walks n down to 0 and reads ctx->buffer[n-1] before the buffer. Guard the strip with n > 0 and bound the re-appended newline so both stay inside ctx->buffer.