refactor: move typed arrow Append helpers to ArrowRowBuilder#821
Merged
Conversation
Move AppendUInt, AppendDouble, AppendBytes, AppendIntList (2 overloads), AppendIntMap, and AppendBinaryMap from the anonymous namespace in manifest_adapter.cc to ArrowRowBuilder, the central home for typed nanoarrow append helpers. Remove the duplicate implementations and update all call sites in ManifestEntryAdapter, ManifestFileAdapter, and their nested methods to use the ArrowRowBuilder helpers.
wgtmac
approved these changes
Jul 7, 2026
Member
|
Nice refactoring! Thank you, @WZhuo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move AppendUInt, AppendDouble, AppendBytes, AppendIntList (2 overloads), AppendIntMap, and AppendBinaryMap from the anonymous namespace in manifest_adapter.cc to ArrowRowBuilder, the central home for typed nanoarrow append helpers. Remove the duplicate implementations and update all call sites in ManifestEntryAdapter, ManifestFileAdapter, and their nested methods to use the ArrowRowBuilder helpers.