Skip to content

Build: Add .venv/ to .gitignore#3626

Merged
kevinjqliu merged 1 commit into
apache:mainfrom
qzyu999:add-dot-venv-to-gitignore
Jul 8, 2026
Merged

Build: Add .venv/ to .gitignore#3626
kevinjqliu merged 1 commit into
apache:mainfrom
qzyu999:add-dot-venv-to-gitignore

Conversation

@qzyu999

@qzyu999 qzyu999 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

.venv/ is the default directory name created by python -m venv .venv and is the convention recommended by the Python docs and modern tooling like uv. Currently .gitignore only ignores venv/ but not .venv/, so contributors using the dotted convention could accidentally stage their virtualenv.

Are these changes tested?

N/A — this is a .gitignore-only change.

Are there any user-facing changes?

No.

@qzyu999 qzyu999 force-pushed the add-dot-venv-to-gitignore branch from d0d9388 to 2f9d6ff Compare July 8, 2026 15:47

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!

@kevinjqliu kevinjqliu merged commit c109e10 into apache:main Jul 8, 2026
6 checks passed
@qzyu999 qzyu999 deleted the add-dot-venv-to-gitignore branch July 8, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants