Read tables with multi-argument transforms as unknown transforms#3630
Open
moomindani wants to merge 2 commits into
Open
Read tables with multi-argument transforms as unknown transforms#3630moomindani wants to merge 2 commits into
moomindani wants to merge 2 commits into
Conversation
Per the V3 spec, readers must read tables with unknown transforms, ignoring them. PyIceberg raised on partition or sort fields with more than one entry in source-ids, so such tables failed to load. Model source-ids on PartitionField and SortField, treat multi-argument transforms as UnknownTransform (null partition values, always-true projection), and serialize per spec: source-id for single-argument transforms, source-ids otherwise. Also fix two latent tolerance bugs: unknown transform names sharing a prefix with known ones (e.g. bucketv2[4]) failed to parse, and str(UnknownTransform) returned "unknown" instead of the original name, corrupting metadata on rewrite. Closes apache#3628
A multi-argument field without a transform previously fabricated
UnknownTransform('None') and masked the missing required field; raise
a clear error instead. Assert explicitly that a single-element
source-ids is normalized onto source-id, and only use the list form
of __str__ for genuinely multi-argument fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3628 (part of #1818)
Rationale for this change
The V3 spec requires readers to read tables with unknown transforms, ignoring them. PyIceberg raised (
Multi argument transforms are not yet supported) on partition or sort fields with more than one entry insource-ids, so loading such tables failed entirely.source-idsonPartitionField/SortFieldand treat multi-argument transforms asUnknownTransform, which already gives the spec behavior (no partition pruning:projectreturns None).source-idonly for single-argument transforms,source-idsonly for multi-argument ones, so specs round-trip faithfully instead of being silently rewritten on the next commit.bucketv2[4]) failed parsing instead of becomingUnknownTransform, andstr(UnknownTransform)returned"unknown"instead of the original name, corrupting the transform name when metadata is rewritten.Evaluating multi-argument transforms on write stays out of scope until the spec defines concrete ones.
Note on other implementations: none currently satisfies the spec's tolerance requirement in full. Java has not implemented
source-ids(its parser requiressource-id), though its transform parsing already matches names exactly andUnknownTransform.toString()preserves the original name — the two tolerance fixes here align PyIceberg with that behavior. iceberg-rust and iceberg-cpp reject unrecognized transform names outright. Thesource-idshandling here follows the spec text directly (partition/sort field JSON: single-argument transforms write onlysource-id, multi-argument onlysource-ids).Are these changes tested?
Yes: eight new tests covering multi-argument parse tolerance (partition and sort), round-trip serialization (
source-idspreserved,source-idomitted, transform name intact), single-element normalization,partition_typeresolution, prefix-colliding unknown transform names, andstr(UnknownTransform)name preservation. All fail without the fix. No new failures intests/table,tests/catalog,tests/utils.Are there any user-facing changes?
Yes: tables using multi-argument transforms now load and scan (without pruning on those fields) instead of raising.
This pull request and its description were written by Claude Fable 5.