Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Adds Windows ARM64 wheel builds to the Python nightly and release GitHub Actions workflows by expanding the build matrix.
Changes:
- Add an additional Windows runner entry intended for ARM64 builds in the nightly PyPI workflow matrix
- Add the same Windows ARM64 runner entry in the release PyPI workflow matrix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release_python_nightly.yml | Adds a Windows ARM runner to the nightly wheel build matrix |
| .github/workflows/release_python.yml | Adds a Windows ARM runner to the release wheel build matrix |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks @ndabas is there any specific reason adding windows? windows ASF machines are proven to be slow and not very stable, more over this would increase CI time and workload for shared ASF pool |
comphead
left a comment
There was a problem hiding this comment.
IMO, ideally to stop windows support, rustc on window machines is not very well performing
|
Thanks for looking into this @comphead. Please correct me if I am wrong, but these workflows run on shared GitHub Actions provided infrastructure, not ASF internal infra? The runner labels The reason why we need this is because we already have Windows AMD64 wheels, and with Windows ARM64 adoption increasing, it would be nice to have ARM64 wheels as well. Nvidia is supporting me in doing this work as they are preparing for the RTX Spark launch, which is an ARM chip, and new devices will have Windows on ARM64 at launch. |
What changes are included in this PR?
Adds Windows ARM64 wheels in the PyPI workflows. It's a trivial change because the workflows are fairly well-structured already, so I did not create an issue for discussion beforehand.
Are these changes tested?
Similar to most other wheels generated in the PyPI workflows, the test is simply to try and install the built wheels, which passes on my fork.
I should note that while the Bindings Python CI workflow currently only tests on a small subset of all supported platform and architecture combinations, so it doesn't make sense to add Windows ARM64 there, currently that would certainly fail because there is no win_arm64 binary wheel available for PyArrow. As that is not a runtime dependency, the wheels should work fine in any case. (This is similar to the linux armv7l case, which also does not have PyArrow wheels available and isn't tested beyond "it compiles".)
We could add a command to the "install wheel" step to actually try importing it as well, just as a quick smoke test.
AI Disclosure
No AI was used for these changes.