Skip to content

feat(datafusion): make IcebergTableProvider::try_new public #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Smith-Cruise wants to merge 1 commit into from
Closed

feat(datafusion): make IcebergTableProvider::try_new public #3207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/integrations/datafusion/public-api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ pub fn iceberg_datafusion::IcebergStaticTableProvider::schema(&self) -> arrow_sc
pub fn iceberg_datafusion::IcebergStaticTableProvider::supports_filters_pushdown(&self, filters: &[&datafusion_expr::expr::Expr]) -> datafusion_common::error::Result<alloc::vec::Vec<datafusion_expr::table_source::TableProviderFilterPushDown>>
pub fn iceberg_datafusion::IcebergStaticTableProvider::table_type(&self) -> datafusion_expr::table_source::TableType
pub struct iceberg_datafusion::table::IcebergTableProvider
impl iceberg_datafusion::IcebergTableProvider
pub async fn iceberg_datafusion::IcebergTableProvider::metadata_table(&self, type: iceberg::inspect::metadata_table::MetadataTableType) -> iceberg::error::Result<iceberg_datafusion::metadata_table::IcebergMetadataTableProvider>
pub async fn iceberg_datafusion::IcebergTableProvider::try_new(catalog: alloc::sync::Arc<dyn iceberg::catalog::Catalog>, namespace: iceberg::catalog::NamespaceIdent, name: impl core::convert::Into<alloc::string::String>) -> iceberg::error::Result<Self>
impl core::clone::Clone for iceberg_datafusion::IcebergTableProvider
pub fn iceberg_datafusion::IcebergTableProvider::clone(&self) -> iceberg_datafusion::IcebergTableProvider
impl core::fmt::Debug for iceberg_datafusion::IcebergTableProvider
Expand Down Expand Up @@ -115,6 +118,9 @@ pub fn iceberg_datafusion::IcebergStaticTableProvider::schema(&self) -> arrow_sc
pub fn iceberg_datafusion::IcebergStaticTableProvider::supports_filters_pushdown(&self, filters: &[&datafusion_expr::expr::Expr]) -> datafusion_common::error::Result<alloc::vec::Vec<datafusion_expr::table_source::TableProviderFilterPushDown>>
pub fn iceberg_datafusion::IcebergStaticTableProvider::table_type(&self) -> datafusion_expr::table_source::TableType
pub struct iceberg_datafusion::IcebergTableProvider
impl iceberg_datafusion::IcebergTableProvider
pub async fn iceberg_datafusion::IcebergTableProvider::metadata_table(&self, type: iceberg::inspect::metadata_table::MetadataTableType) -> iceberg::error::Result<iceberg_datafusion::metadata_table::IcebergMetadataTableProvider>
pub async fn iceberg_datafusion::IcebergTableProvider::try_new(catalog: alloc::sync::Arc<dyn iceberg::catalog::Catalog>, namespace: iceberg::catalog::NamespaceIdent, name: impl core::convert::Into<alloc::string::String>) -> iceberg::error::Result<Self>
impl core::clone::Clone for iceberg_datafusion::IcebergTableProvider
pub fn iceberg_datafusion::IcebergTableProvider::clone(&self) -> iceberg_datafusion::IcebergTableProvider
impl core::fmt::Debug for iceberg_datafusion::IcebergTableProvider
Expand Down
4 changes: 2 additions & 2 deletions crates/integrations/datafusion/src/table/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ impl IcebergTableProvider {
///
/// Loads the table once to get the initial schema, then stores the catalog
/// reference for future metadata refreshes on each operation.
pub(crate) async fn try_new(
pub async fn try_new(
catalog: Arc<dyn Catalog>,
namespace: NamespaceIdent,
name: impl Into<String>,
Expand All @@ -97,7 +97,7 @@ impl IcebergTableProvider {
})
}

pub(crate) async fn metadata_table(
pub async fn metadata_table(
&self,
r#type: MetadataTableType,
) -> Result<IcebergMetadataTableProvider> {
Expand Down
Loading