fix(transform): compute year and month in UTC - #3237
Open
jaideeppyne wants to merge 1 commit into
Open
jaideeppyne wants to merge 1 commit into
jaideeppyne wants to merge 1 commit into
Conversation
Year and Month used Arrow date_part, which converts into the array's timezone tag before reading the calendar field. Iceberg computes those transforms in UTC, and transform_literal already did. Retag timestamp arrays as +00:00 before date_part so array and literal paths agree for non-UTC tags. Closes apache#3142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Year::transformandMonth::transformcalled Arrowdate_part, which converts each timestamp into the array's timezone tag before reading year/month. Iceberg computes those transforms in UTC (DateTimeUtil/transform_literal), so a non-UTC tag produced the wrong partition value near a year or month boundary.Timestamp arrays are retagged as
+00:00(same epoch values) beforedate_part.DayandHouralready work from the raw epoch and are unchanged.Are these changes tested?
Unit test
test_year_and_month_ignore_non_utc_timezone_tagcovers-1micros taggedAsia/Kathmandu, which must stay year/month-1rather than0. Existing year/month array tests still pass.AI Disclosure