fix(python): raise instead of panicking in the manifest bindings - #3241
Open
rambleraptor wants to merge 1 commit into
Open
rambleraptor wants to merge 1 commit into
rambleraptor wants to merge 1 commit into
Conversation
There's some assorted places that we need to raise errors instead of panicking.
Contributor
Author
|
@kevinjqliu fyi since you've done a lot of work on pyiceberg-core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This changes a handful of Python functions to return PyResult, which allows us to propagate errors up.
It also changes the type signature of
PyManifest.partitions()to allow None.Neither of these breaks the current type signatures, although the
partitions()change may result in a Python loop throwing a ValueError.Are these changes tested?
Included unit tests. Pretty basic test plan:
AI Disclosure
Claude built this PR out under my direct supervision and questioning. I've been doing a lot of Rust investigation as part of my work on PyIceberg. The community has had a lot of great conversations around AI! I haven't sent many PRs to iceberg-rust and hoping that these clear the bar.
Claude had no part in writing my PR description or (hastily written) GitHub issue.