refactor(reader): build Arrow reader metadata once - #3242
Open
kamcheungting-db wants to merge 1 commit into
Open
kamcheungting-db wants to merge 1 commit into
kamcheungting-db wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ArrowReaderMetadatabuilding in theprocessfunction of FileScanTaskReader #2860.What changes are included in this PR?
This PR extracts field-ID, INT96 coercion and row-number virtual columns assignment logic from
FileScanTaskReader::processto an new methodFileScanTaskReader::ArrowReaderMetadata. It helps reducing the cost of repeatedly object clone and simplify the logic.Are these changes tested?
cargo fmt --all -- --checkcargo check -p iceberg --libcargo clippy -p iceberg --lib --offline -- -D warningscargo test -p iceberg --lib arrow::reader::pipeline::tests— 47 passedNo new tests were added because this is a behavior-preserving refactor and the
existing pipeline tests cover each affected path.
AI Disclosure