Repository navigation
fix(reader): handle Parquet TIMESTAMP(MILLIS) in pruning, filtering and projection #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hcrosse
wants to merge
11
commits into
apache:main
Choose a base branch
from
hcrosse:millis-timestamps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+785
−80
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8882985
fix(reader): respect Parquet timestamp units when pruning
hcrosse 7b9ca6b
fix(reader): compare millisecond timestamp columns at microsecond pre…
hcrosse b0b6c79
fix(reader): read Parquet millisecond timestamps
hcrosse 4b58d26
Merge branch 'main' into millis-timestamps
hcrosse ef518af
fix(reader): keep rejecting millisecond columns under nanosecond fields
hcrosse 1f372d1
Merge branch 'main' into millis-timestamps
hcrosse 0d1b97c
Merge branch 'main' into millis-timestamps
hcrosse 770dea9
fix(reader): reject millisecond columns that do not match the table type
hcrosse 9b7cb5f
fix(reader): fail promotion casts with DataInvalid
hcrosse 79a1cfa
fix(reader): cover more timestamp units in tests
hcrosse b322785
Merge branch 'main' into millis-timestamps
hcrosse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads-up: I think this overlaps with #3540, which is approved. It converts the filter columns to the table schema with a
RecordBatchTransformeringet_row_filter, so a millisecond column already reaches the predicate asTimestamp(µs). With that, I think this widening is no longer needed. #3540 also compares milliseconds under the nanosecond types exactly, while this path widens the column to µs and then truncates the ns literal. The two PRs conflict inpredicate_visitor.rsandrow_filter.rs. If #3540 lands first, I think this commit and its two unit tests could go, and the end-to-end test could stay. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. If #3540 lands first, I'll drop the widening commit and its two unit tests and keep the end to end test.