Core, ORC: surface struct-level null counts for content stats - #17844
Open
bujjibabukatta wants to merge 1 commit into
Open
Core, ORC: surface struct-level null counts for content stats#17844bujjibabukatta wants to merge 1 commit into
bujjibabukatta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes one direction for #17463 (open investigation issue, no
consensus yet): let ORC surface struct-level null counts it already
computes, and let V4 content stats store them.
Root Cause
ColumnStatistics[]includes real null-count data forstruct columns, but
StatsColumnsVisitor.record()only ever addedchildren's field IDs — the struct's own ID was discarded.
fieldStatsStruct()excluded all nested types(struct, map, list) uniformly via
isNestedType(), so structs hadno way to store counts even when a writer could supply them.
Read side is unaffected —
InclusiveMetricsEvaluatoralready does ageneric field-ID lookup with no leaf/struct distinction.
Fix
OrcMetrics.java—StatsColumnsVisitor.record()now also addsthe struct's own field ID via
ORCSchemaUtil.icebergID(record).Bounds unaffected (struct
ColumnStatisticsmatches noinstanceofbranch infromOrcMin/fromOrcMax).StatsUtil.java—fieldStatsStruct()returns a reducedvalue_count/null_value_count-only struct forStructTypeinstead of
null. Map/list still excluded as before.