Core: Remove deprecated ThreadPools.WORKER_THREAD_POOL_SIZE_PROP - #17848
Closed
nanjeshramesh wants to merge 1 commit into
Closed
Core: Remove deprecated ThreadPools.WORKER_THREAD_POOL_SIZE_PROP#17848nanjeshramesh wants to merge 1 commit into
nanjeshramesh wants to merge 1 commit into
Conversation
This field was deprecated in favor of SystemConfigs.WORKER_THREAD_POOL_SIZE and marked for removal in 1.12.0. Now that 1.11.0 has shipped, it's due. It has no remaining callers anywhere in the repo, so this is a clean removal. Added the corresponding accepted-break entry to .palantir/revapi.yml, matching the pattern already used for other deprecations scheduled for removal in 1.12.0. Generated-by: Claude Code
nanjeshramesh
changed the title
Contributor
|
hey @nanjeshramesh, I already have the #17812 approved for this just FYI |
Author
Thanks for the heads up @dramaticlly ! Good to know #17812 already covers this, closing this one in favor of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16445.
Searched the codebase for every method or field marked
@deprecated ... will be removed in 1.12.0(the specific removal target, not the ones freshlydeprecated during 1.12.0's own development cycle with a later removal
version). Only one matched:
ThreadPools.WORKER_THREAD_POOL_SIZE_PROP, analias for
SystemConfigs.WORKER_THREAD_POOL_SIZE.propertyKey()that's had nocallers anywhere in the repo for a while.
Removed it and added the corresponding accepted-break entry to
.palantir/revapi.yml, filed under the same1.11.0section otherdeprecations scheduled for 1.12.0 removal are already tracked under, to match
existing convention.
Verified:
iceberg-corecompiles cleanly,revapipasses (confirms theaccepted-break entry is correctly formatted), and there's no dedicated test
file for
ThreadPoolssince this field was never covered by one.AI Disclosure
removal target of 1.12.0, since 1.11.0 has shipped, per issue Remove deprecated methods for 1.12.0 #16445.