GCP: Avoid duplicate BigQuery namespace loads - #17871
Open
charliec05 wants to merge 1 commit into
Open
Conversation
Delegate namespace validation to removeParameters so removing namespace properties performs a single remote load. Generated-by: Codex
uros-b
reviewed
Aug 29, 2026
Comment on lines
252
to
253
| Preconditions.checkNotNull(properties, "Invalid properties to remove: null"); | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| Preconditions.checkNotNull(properties, "Invalid properties to remove: null"); | |
| Preconditions.checkNotNull(properties, "Invalid properties to remove: null"); |
Member
There was a problem hiding this comment.
The suggested change looks the same as the original code.
Member
There was a problem hiding this comment.
(it's an uber nit, about removing the extra newline)
ebyhr
reviewed
Aug 30, 2026
Comment on lines
-258
to
-260
| if (properties.isEmpty()) { | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
What's the motivation to remove this condition? I don't think we need to call BigQueryMetastoreClient#removeParameters when properties is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes removeProperties consistent with setProperties while preserving missing-namespace validation.
Closes #17059
Testing
./gradlew :iceberg-bigquery:testAI Disclosure