Repository navigation
GH-4408: Fix overall timeout for multiple update operations - #4426
Open
deepikavalluru wants to merge 2 commits into
Open
deepikavalluru wants to merge 2 commits into
deepikavalluru wants to merge 2 commits into
Conversation
rvesse
requested changes
Nov 17, 2026
| .update(TWO_OPS) | ||
| .timeout(600, TimeUnit.SECONDS) | ||
| .execute()); | ||
| } |
Member
There was a problem hiding this comment.
The test doesn't actually have any assertions in it, while I appreciate this is testing something that previously would have errored you still need to assert that the updates are now successfully applied
Author
There was a problem hiding this comment.
Thanks for reviewing! I'll work on adding assertions to verify that the updates are successfully applied.
Author
There was a problem hiding this comment.
I've added assertions to verify that both update operations are successfully applied and reran the tests. The build is successful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #
Pull request Description:
Fixes #4408.
The remaining overall timeout was incorrectly calculated for the second and subsequent update operations.
The local variable
remainingOverallTimeoutMilliswas initialized to-1on every invocation. Subtracting the elapsed time from this value caused the remaining timeout to become zero, resulting in immediate cancellation.This change calculates the remaining timeout using the original configured overall timeout minus the elapsed time.
Changes
Testing
TestUpdateTimeoutMultiOpBy submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.