fix(security-issue-import): require a positive GHSA query on every scan - #1128
Merged
Merged
Conversation
The skill already says not to exclude `notifications@github.com`
wholesale, because that sender carries both tracker-mirror chatter and
GHSA-relayed inbound reports. That rule is correct but negative, and
negative rules are not self-enforcing.
An exclusion added anywhere for noise reduction — in the candidate
query, in a project override, in a hand-edited one-off — removes the
entire GHSA intake channel. The resulting miss is invisible: nothing
reports that a report was filtered out, so the scan looks clean and the
advisory is simply never seen. A downstream adopter lost an
incomplete-fix follow-up advisory to exactly this, and caught it only
because the operator independently knew the report existed.
Adds a positive counterpart that every import scan runs alongside the
candidate-listing query:
from:notifications@github.com newer_than:<window>
(GHSA OR "Report a vulnerability" OR "security advisory")
Because it does not depend on the other query's filter list, the GHSA
channel is checked by construction and cannot be filtered away by an
exclusion elsewhere. Cost is one extra search per scan.
Also documents the 404 case on the advisory record API: it means the
operator is not yet a collaborator on that specific advisory — an
access state, not a missing advisory — and names the admin hand-off
needed before the record API and reporter-reply path work.
Generated-by: Claude Code (Claude Opus 5)
potiuk
added
family:security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The skill already says not to exclude
notifications@github.comwholesale, because that sender carries both tracker-mirror chatter and GHSA-relayed inbound reports. That rule is correct, but it is negative — and negative rules are not self-enforcing.Adds a positive counterpart that every import scan runs alongside the candidate-listing query:
Motivation
An exclusion added anywhere for noise reduction — in the candidate query, a project override, a hand-edited one-off — removes the entire GHSA intake channel. The resulting miss is invisible: nothing reports that a report was filtered out, so the scan looks clean and the advisory is simply never seen.
A downstream adopter lost an incomplete-fix follow-up advisory to exactly this, and caught it only because the operator independently knew the report existed. That is not a control — it is luck.
Because the new query does not depend on the other query's filter list, the GHSA channel is checked by construction and cannot be filtered away by an exclusion elsewhere. Cost is one extra search per scan.
Also
Documents the 404 case on the advisory record API. A 404 there means the operator is not yet a collaborator on that specific advisory — an access state, not a missing advisory — and the fix is an admin hand-off (someone with advisory-admin rights adds the operator) before the record API and the reporter-reply path work. That distinction is easy to misread as "no such advisory" and abandon.
Test plan
prek run --filespasses on both files. The in-hook lychee confirms the new cross-reference anchor (#security-issue-import--ghsa-advisory-query-mandatory-second-pass) resolves against the doctoc-generated TOC, andcheck-placeholdersconfirms the added text uses only<upstream>/<GHSA>/<window>placeholders.🤖 Generated with Claude Code