fix(_template): drop Apache Airflow residue from the templates - #1132
Merged
potiuk merged 1 commit intoAug 30, 2026
Merged
Conversation
The `_template` scaffolds are meant to be project-agnostic — an adopter copies them and fills in placeholders. Four spots still carried the framework's original adopter's specifics as if they were generic: - `reviewer-roster.md`: the "shape per entry" sample used `airflow/jobs/` as its path-prefix example, unmarked, and the Notes section repeated it. Now `src/scheduler/`, which reads as a shape rather than as one project's tree. - `security-intake-config.md`: the ASF defaults were described as reproducing "the Apache Airflow security-team workflow". They reproduce the standard ASF one; naming a single project made the sentence look like a calibration an adopter had to match. - `pr-management-quick-merge-config.md`: the `tier_b_allow_globs` default shipped `**/example_dags/**`, which is meaningful only in an Airflow tree. Replaced with `**/examples/**` + `**/example_*/**` — generic, and a superset of the old glob, so an Airflow adopter's example-DAG PRs stay in tier B. The prose above the globs no longer describes the default set as Airflow-shaped. - `candidate-rules.md`: the skill's built-in default list carries the same globs, updated in lock-step so template and skill do not drift. Deliberately left alone: every spot that already marks itself as an example — the `release-management-config.md` "filled example" section, the `mentoring-welcome-config.md` filled-in block, and the `Example: apache/airflow-...` cells. Those are calibration aids, not residue. Generated-by: Claude Code (Claude Opus 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/magpie-setup upgrade's Step 6d template-genericity audit flagged these on an adopter repo. The_templatescaffolds are meant to be project-agnostic — an adopter copies them and fills in placeholders — but four spots carried the framework's original adopter's specifics as if they were generic:reviewer-roster.mdairflow/jobs/as the unmarked path-prefix sample (shape comment + Notes)src/scheduler/— reads as a shape, not one project's treesecurity-intake-config.mdpr-management-quick-merge-config.mdtier_b_allow_globsshipped**/example_dags/**, meaningful only in an Airflow tree; prose called the defaults Airflow-shaped**/examples/**+**/example_*/**, and prose says "a Python monorepo"candidate-rules.mdThe glob replacement is a superset of the old one —
**/example_*/**still matchesexample_dags/, so an Airflow adopter's example-DAG PRs stay in tier B.Deliberately left alone: everything that already marks itself as an example — the
release-management-config.md"filled example" section, thementoring-welcome-config.mdfilled-in block, and theExample: apache/airflow-…cells. Those are calibration aids, not residue.