feat(i18n-ko): localize Desktop slice 2 catalogs - #4710
Open
testikun wants to merge 4 commits into
Open
Conversation
testikun
force-pushed
the
codex/issue-3976-ko
branch
2 times, most recently
from
September 4, 2026 07:44
9a15a0d to
df49185
Compare
added 4 commits
September 4, 2026 16:45
Generated-by: OpenAI Codex
Refresh the Korean quit dialog catalog for the current main branch, add a localized settings regression test, and keep real UI evidence out of the source diff so it can live in the PR description.\n\nGenerated-by: OpenAI Codex
Carry the Korean provider and usage copy across the latest model-settings and usage-trace contracts, with regression assertions for the newly added fields.\n\nGenerated-by: OpenAI Codex
testikun
force-pushed
the
codex/issue-3976-ko
branch
from
September 4, 2026 08:47
17d71c7 to
7c133a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ko) catalog entries for the remaining Desktop domains in issue feat(i18n-ko): desktop slice 2 — remaining settings/conversation/artifact/browser/mcp/plan-mode #3976: conversation, artifacts, browser, external-session import, MCP, Plan Mode, and settings.UiLocaleKorean variants and localize dynamic Desktop labels/messages, including health capabilities, conversation inspector metadata, permissions/retries, and provider context-window copy.Pre-submit review
en/kokeys and dynamic copy is covered.packages/uicatalogs is outside this Desktop slice and belongs to the shared UI follow-up (feat(i18n-ko): shared UI — packages/ui and core error copy #3978).Validation
npm --workspace @maka/desktop run build:with-depsnpm --workspace @maka/desktop run typechecknpm --workspace @maka/desktop run check:architecturegit diff --checkdf4918571; current head7c133a4b7is the rebased equivalent onapache/main19ac204ab, opened Korean Settings, verified the localized Data page, navigated to Sub-agents, and captured the resulting real window. These are direct App captures, not mockups or generated images.The repository Playwright Electron launcher currently stalls during its macOS inspector/CDP handshake before the first window is created; an existing #4701 test reproduces the same host-level failure. The direct visible real-window/CDP verification above completed successfully, and CI will exercise the committed Playwright regression test on Linux.
Real App screenshots
Korean Data settings
Korean Sub-agents settings
Fixes #3976
AI use