Skip to content

feat(i18n-ko): core — add ko to UiLocale model - #5100

Draft
me2seeks wants to merge 1 commit into
mainfrom
stack/i18n-ko-core
Draft

feat(i18n-ko): core — add ko to UiLocale model#5100
me2seeks wants to merge 1 commit into
mainfrom
stack/i18n-ko-core

Conversation

@me2seeks

@me2seeks me2seeks commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Korean i18n official core bridge

This is the official apache/maka stack base for Korean UI locale integration. It recreates the reviewed implementation from #5011 at 36a4377e66d3e2b61f722543dea73a43e8a52344 on current main as one squash-shaped core layer.

It deliberately remains a draft and must not merge on its own: adding ko to the closed UiLocale vocabulary makes remaining locale maps in the CLI, desktop, UI, native, Storybook, and E2E slices incomplete. Downstream slice PRs stack on this branch; only the complete, green stack is eligible for merge.

Provenance and credit

Validation

  • npm --workspace @maka/core run build
  • affected core suites: 83/83 passing
  • git diff --check

Recreate the reviewed core layer from #5011 on the official integration
stack. Add Korean to the closed UI locale vocabulary, system resolution,
and Intl mapping; complete the three @maka/core UI catalogs required by
that strict contract.

Reviewed source: #5011 at 36a4377.
Refs #3975

Generated-by: Claude Code
Co-authored-by: heeoneie <68272931+heeoneie@users.noreply.github.com>
@github-actions github-actions Bot added the effort/M Under 500 readable lines label Sep 9, 2026

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings in this core layer.

This exact head, a193ad8d1f5d00886ec4d182d9fd0b5a445c9c9c, is suitable only as the draft base of the atomic Korean-locale stack. It must not merge into main independently: adding ko to the closed UiLocale union intentionally makes incomplete downstream locale maps fail to compile until the remaining stack layers are present.

The implementation keeps the locale contract strict, recognizes Korean system tags without accidentally matching Konkani, maps the internal ko value to the ko-KR Intl tag, and completes the three catalogs required for @maka/core to build. I verified that this bridge commit's combined patch ID exactly matches the contributor's reviewed #5011 source range through 36a4377e66d3e2b61f722543dea73a43e8a52344; the commit also preserves the requested author, co-author, and Generated-by: Claude Code attribution.

@maka/core builds successfully, and the four affected suites pass 83/83. As a regression check, I removed Korean system-language recognition and returned an incorrect Intl tag; 11 locale assertions then failed, including the supported Korean tag matrix, language-order behavior, and Intl mapping. Biome on all eight changed files, the ASF header audit, and git diff --check also pass.

The hosted test check is red on this head. I inspected the failure: the build reaches and passes @maka/core, then stops on the expected downstream CLI maps that do not yet have a ko branch. This is the intended stack boundary, not a green merge gate. A synthetic merge with current main (ba849f404991af1f374df38a352f3ff5dc29d2ae) is textually clean and preserves this eight-file patch, but the PR should remain a draft until the complete stack is assembled and the full hosted check is green.


Automated review notice: This comment was posted by an automated review agent operated by jackwener. It is not an independent human review and does not replace one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants