Skip to content

Revert "Remove use of deprecated MessageUtils (#264)" - #268

Open
gnodet wants to merge 3 commits into
apache:masterfrom
gnodet:revert-pr-264
Open

gnodet wants to merge 3 commits into
apache:masterfrom
gnodet:revert-pr-264

Conversation

@gnodet

@gnodet gnodet commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

This reverts commit 2600165 (PR #264).

Reverting while we figure out the correct approach for replacing MessageUtils.

@gnodet
gnodet requested review from elharo and hboutemy October 6, 2026 12:28

@elharo elharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was correct and deliberate. It should not be reverted.

@gnodet

gnodet commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

This change was correct and deliberate. It should not be reverted.

It was deliberate but incorrect, as it removes a feature for no good reason. Alternatives are: revert the maven-shared-util upgrade or require maven 3.10.

@hboutemy hboutemy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Guillaume: as a user, color is very useful

@hboutemy

hboutemy commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

on where to put MessageUtils, it has always been a hard question: shared-utils was a good fit apache/maven-shared-utils@2ea1217 as not possible in Maven core, and not supposed to be retired as it was supposed to replace plexus-utils https://github.com/apache/maven-shared-utils/tree/d8b72d30042af167a8dab103f80378642499889a / https://issues.apache.org/jira/browse/MSHARED-236

I don't know if we have any other shared component where it could make sense https://maven.apache.org/shared/index.html

@gnodet

gnodet commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@gnodet
gnodet requested a review from elharo October 7, 2026 19:33
@slachiewicz

Copy link
Copy Markdown
Member

I've updated description in maven-shared-utils to make clear about path apache/maven-shared-utils#443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants