Conversation
…an fallback When session.getRootDirectory() throws IllegalStateException (embedded usage), log a debug message before falling back to the system temp directory. Also initialise rootDir to null explicitly for clarity. Addresses review feedback from @desruisseaux on apache#362.
gnodet-bot
approved these changes
Oct 1, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Solid — replaces a silent empty catch with an explicit debug log (exception chained), and moves the null init to the declaration for clarity. No behavioral change in the normal Maven CLI path; the fallback to system temp dir was already working, this just makes it observable at debug level for embedded usage.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
session.getRootDirectory()throwsIllegalStateException(embedded/standalone usage without a root directory), log a debug message before falling back to the system temp directory. Also initialisesrootDirtonullexplicitly for clarity.Note: in a standard Maven 4 CLI build,
getRootDirectory()never throws — the root directory is always resolved before mojo execution. This fallback path is only reachable from embedded usage.Addresses review feedback from @desruisseaux on #362.